On Thu, 30 May 2024 at 15:25, Nicholas Piggin <npig...@gmail.com> wrote:
> There is no need to use /dev/shm for file-backed memory devices, and
> on Gitlab CI the tmpfs mount is too small to be usable for migration
> tests. Switch to using a regular file in /tmp/ which will usually have
> more space available.
...
> - if (args->use_shmem) {
> - shmem_path = g_strdup_printf("/dev/shm/qemu-%d", getpid());
> - shmem_opts = g_strdup_printf(
> + if (args->use_memfile) {
> + memfile_path = g_strdup_printf("/%s/qemu-%d", tmpfs, getpid());
> + memfile_opts = g_strdup_printf(
...
> g_autofree char *uri = g_strdup_printf("unix:%s/migsocket", tmpfs);
> QTestState *from, *to;
...
> g_autofree char *uri = g_strdup_printf("file:%s/%s", tmpfs,
> FILE_TEST_FILENAME);
* Maybe the 'tmpfs' variable needs to be renamed to indicate that it
uses '/tmp/' or '/var/tmp' directory to create temporary files. And it
is not in memory tmpfs(5) used for shared memory '/dev/shm'. Commit
message above says 'tmpfs mount is too small' and above calls continue
to use 'tmpfs' variable to create temporary files. It's a little
confusing.
Otherwise patch looks okay.
Reviewed-by: Prasad Pandit <p...@fedoraproject.org>
Thank you.
---
- Prasad
