On Fri, 31 May 2024 at 09:54, Alex Bennée <alex.ben...@linaro.org> wrote: > > Brian Cain <quic_bc...@quicinc.com> writes: > > Related: would a .clang-format file also be useful? git-clang-format > > can be used to apply formatting changes only on the code that's been > > changed. > > As a pre-commit hook? Or via something like clangd?
I think last time somebody looked at clangd it wasn't quite flexible enough to format code to QEMU's style preferences. But that was some years ago, so I might be misremembering or the situation might have changed. In terms of project consensus, I think "here's tooling/config you can use to follow our formatting preferences if you like" is probably a better place to start than anything that is an automatically-applied-by-default check. (For the semihosting-tests I wouldn't bother, because they get almost no contributions: 8 commits in the last 5 years.) thanks -- PMM
