Hi Peter,
On 31/5/24 16:21, Peter Maydell wrote:
Since commit 83aa1baa069c we have been running the build for Coverity
Scan as a Gitlab CI job, rather than the old setup where it was run
on a local developer's machine. This is working well, but the
absolute paths of files are different for the Gitlab CI job, which
means that the regexes we use to identify Coverity components no
longer work. With Gitlab CI builds the file paths are of the form
/builds/qemu-project/qemu/accel/kvm/kvm-all.c
rather than the old
/qemu/accel/kvm/kvm-all.c
and our regexes all don't match.
Update all the regexes to start with .*/qemu/ . This will hopefully
avoid the need to change them again in future if the build path
changes again.
This change was made with a search-and-replace of (/qemu)?
to .*/qemu .
Signed-off-by: Peter Maydell <peter.mayd...@linaro.org>
---
As usual with COMPONENTS.md changes, somebody with Coverity admin
access needs to make all the changes by hand in the GUI once this
has gone through code review :-(
If there are any other changes we want to make to our component
regexes, now would be a great time to suggest them, because this
change is going to involve "delete every existing component and
recreate"...
---
scripts/coverity-scan/COMPONENTS.md | 104 ++++++++++++++--------------
1 file changed, 52 insertions(+), 52 deletions(-)
diff --git a/scripts/coverity-scan/COMPONENTS.md
b/scripts/coverity-scan/COMPONENTS.md
index 1537e49cd5a..98d4bcd6a50 100644
--- a/scripts/coverity-scan/COMPONENTS.md
+++ b/scripts/coverity-scan/COMPONENTS.md
@@ -1,157 +1,157 @@
This is the list of currently configured Coverity components:
block
- ~
(/qemu)?(/block.*|(/include?)/(block|storage-daemon)/.*|(/include)?/hw/(block|ide|nvme)/.*|/qemu-(img|io).*|/util/(aio|async|thread-pool).*)
+ ~
.*/qemu(/block.*|(/include?)/(block|storage-daemon)/.*|(/include)?/hw/(block|ide|nvme)/.*|/qemu-(img|io).*|/util/(aio|async|thread-pool).*)
util/block-helpers.[ch]
I'd put hw/block/ to another bucket that the block subsystem.
char
- ~ (/qemu)?(/qemu-char\.c|/include/sysemu/char\.h|(/include)?/hw/char/.*)
+ ~ .*/qemu(/qemu-char\.c|/include/sysemu/char\.h|(/include)?/hw/char/.*)
Is 'char' the same as 'chardev'?
crypto
- ~
(/qemu)?((/include)?/crypto/.*|/hw/.*/.*crypto.*|(/include/sysemu|/backends)/cryptodev.*)
+ ~
.*/qemu((/include)?/crypto/.*|/hw/.*/.*crypto.*|(/include/sysemu|/backends)/cryptodev.*)
Maybe worth covering host/include/*/host/crypto/?
disas
- ~ (/qemu)?((/include)?/disas.*)
+ ~ .*/qemu((/include)?/disas.*)
Missing:
target/avr/disas.c
target/loongarch/disas.c
target/openrisc/disas.c
target/rx/disas.c
migration
- ~ (/qemu)?((/include)?/migration/.*)
+ ~ .*/qemu((/include)?/migration/.*)
Not sure about:
hw/vfio/migration.c
monitor
- ~ (/qemu)?(/qapi.*|/qobject/.*|/monitor\..*|/[hq]mp\..*)
+ ~ .*/qemu(/qapi.*|/qobject/.*|/monitor\..*|/[hq]mp\..*)
Apparently the pattern is now foo-[hq]mp-cmds.[ch].
Not matched:
hmp-commands-info.hx
hmp-commands.hx
hw/virtio/virtio-qmp.[ch]
include/qapi/qmp-event.h
job-qmp.c
monitor/qemu-config-qmp.c
python/qemu/qmp/events.py
scripts/python_qmp_updater.py
tests/unit/test-qmp-event.c
Not sure about (not covered in testlibs):
tests/qtest/libqmp.c
tests/qtest/libqmp.h
trace
- ~ (/qemu)?(/.*trace.*\.[ch])
+ ~ .*/qemu(/.*trace.*\.[ch])
user
- ~
(/qemu)?(/linux-user/.*|/bsd-user/.*|/user-exec\.c|/thunk\.c|/include/user/.*)
+ ~
.*/qemu(/linux-user/.*|/bsd-user/.*|/user-exec\.c|/thunk\.c|/include/user/.*)
xen
- ~ (/qemu)?(.*/xen.*)
+ ~ .*/qemu(.*/xen.*)
We could match .*xen.* like trace (ditto other accelerators).
hvf
- ~ (/qemu)?(.*/hvf.*)
+ ~ .*/qemu(.*/hvf.*)
kvm
- ~ (/qemu)?(.*/kvm.*)
+ ~ .*/qemu(.*/kvm.*)
tcg
- ~ (/qemu)?(/accel/tcg|/replay|/tcg)/.*
+ ~ .*/qemu(/accel/tcg|/replay|/tcg)/.*
sysemu
- ~ (/qemu)?(/system/.*|/accel/.*)
+ ~ .*/qemu(/system/.*|/accel/.*)
