Incorrect $SUBJECT - it claims to be removing monitor_fdset_dup_fd_add but actually removes monitor_fdset_dup_fd_find.
On Thu, May 23, 2024 at 04:05:34PM -0300, Fabiano Rosas wrote: > From: Peter Xu <pet...@redhat.com> > > This function is not needed, one remove function should already work. > Clean it up. > > Here the code doesn't really care about whether we need to keep that dupfd > around if close() failed: when that happens something got very wrong, > keeping the dup_fd around the fdsets may not help that situation so far. > > Cc: Dr. David Alan Gilbert <d...@treblig.org> > Cc: Markus Armbruster <arm...@redhat.com> > Cc: Philippe Mathieu-Daudé <phi...@linaro.org> > Cc: Paolo Bonzini <pbonz...@redhat.com> > Cc: Daniel P. Berrangé <berra...@redhat.com> > Signed-off-by: Peter Xu <pet...@redhat.com> > [add missing return statement, removal during traversal is not safe] > Signed-off-by: Fabiano Rosas <faro...@suse.de> > --- > include/monitor/monitor.h | 1 - > monitor/fds.c | 28 ++++++---------------------- > stubs/fdset.c | 5 ----- > util/osdep.c | 15 +-------------- > 4 files changed, 7 insertions(+), 42 deletions(-) With $SUBJECT fixed Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
