Hi Jared!
On 29/05/2024 17.43, jro...@linux.ibm.com wrote:
From: Jared Rossi <jro...@linux.ibm.com>
Currently, stuctures defined in both hw/s390x/ipl.h and pc-bios/s390-ccw/iplb.h
Typo: s/stuctures/structures/
must be kept in sync, which is prone to error. Instead, create a new directory
at include/hw/s390x/ipl/ to contain the definitions that must be shared.
Signed-off-by: Jared Rossi <jro...@linux.ibm.com>
---
hw/s390x/ipl.h | 113 +-------------------------------
include/hw/s390x/ipl/qipl.h | 126 ++++++++++++++++++++++++++++++++++++
pc-bios/s390-ccw/iplb.h | 84 ++----------------------
pc-bios/s390-ccw/Makefile | 2 +-
4 files changed, 133 insertions(+), 192 deletions(-)
create mode 100644 include/hw/s390x/ipl/qipl.h
...
diff --git a/pc-bios/s390-ccw/Makefile b/pc-bios/s390-ccw/Makefile
index acfcd1e71a..a771439acf 100644
--- a/pc-bios/s390-ccw/Makefile
+++ b/pc-bios/s390-ccw/Makefile
@@ -3,7 +3,7 @@ all: build-all
@true
include config-host.mak
-CFLAGS = -O2 -g
+CFLAGS = -O2 -g -I $(SRC_PATH)/../..//include/hw/s390x/ipl
Duplicate slash -----------------------^
Apart from these two nits, patch looks fine to me.
Thomas
