On Mon, Jun 03, 2024 at 01:54:15PM +0200, Markus Armbruster wrote: > Date: Mon, 03 Jun 2024 13:54:15 +0200 > From: Markus Armbruster <arm...@redhat.com> > Subject: Re: [PATCH] hw/core: Rename CpuTopology to CPUTopology > > Zhao Liu <zhao1....@intel.com> writes: > > > Use CPUTopology to honor the generic style of CPU capitalization > > abbreviations. > > > > Signed-off-by: Zhao Liu <zhao1....@intel.com> > > Is CPUFoo really more common than CpuFoo? It isn't in the qapi > schema...
Hi Markus, do you think this style needs to be standardized? All-caps cases, like the widely used CPUState. And the common structures declared in include/qemu/typedefs.h, are all using CPU, not Cpu... If you feel this is necessary, I'd be happy to help more places change their names to standardize their style...