On Fri, May 31, 2024 at 05:27:51PM -0300, Daniel Henrique Barboza wrote: > Hi, > > This is a series that is being spun from the reviews given on patch 1 > [1]. We'll fix some DT validation issues we have in the 'virt' machine > [2] that aren't related to missing extensions in the DT spec. > > I'll leave to maintainers to squash the patches as they see fit. I > split it this way to make it easier to bissect possible bugs that these > individual changes can cause. > > These are the types of DT warnings solved by this series: > > /home/danielhb/work/qemu/riscv64_virt.dtb: aplic@d000000: $nodename:0: > 'aplic@d000000' does not match '^interrupt-controller(@[0-9a-f,]+)*$' > from schema $id: > http://devicetree.org/schemas/interrupt-controller/riscv,aplic.yaml# > /home/danielhb/work/qemu/riscv64_virt.dtb: aplic@d000000: compatible:0: > 'riscv,aplic' is not one of ['qemu,aplic'] > from schema $id: > http://devicetree.org/schemas/interrupt-controller/riscv,aplic.yaml# > /home/danielhb/work/qemu/riscv64_virt.dtb: aplic@d000000: compatible: > ['riscv,aplic'] is too short > from schema $id: > http://devicetree.org/schemas/interrupt-controller/riscv,aplic.yaml# > /home/danielhb/work/qemu/riscv64_virt.dtb: aplic@d000000: Unevaluated > properties are not allowed ('compatible' was unexpected) > from schema $id: > http://devicetree.org/schemas/interrupt-controller/riscv,aplic.yaml# > (...) > /home/danielhb/work/qemu/riscv64_virt.dtb: imsics@28000000: $nodename:0: > 'imsics@28000000' does not match '^interrupt-controller(@[0-9a-f,]+)*$' > from schema $id: > http://devicetree.org/schemas/interrupt-controller/riscv,imsics.yaml# > /home/danielhb/work/qemu/riscv64_virt.dtb: imsics@28000000: compatible:0: > 'riscv,imsics' is not one of ['qemu,imsics'] > from schema $id: > http://devicetree.org/schemas/interrupt-controller/riscv,imsics.yaml# > /home/danielhb/work/qemu/riscv64_virt.dtb: imsics@28000000: compatible: > ['riscv,imsics'] is too short > from schema $id: > http://devicetree.org/schemas/interrupt-controller/riscv,imsics.yaml# > /home/danielhb/work/qemu/riscv64_virt.dtb: imsics@28000000: '#msi-cells' is a > required property > from schema $id: > http://devicetree.org/schemas/interrupt-controller/riscv,imsics.yaml# > /home/danielhb/work/qemu/riscv64_virt.dtb: imsics@28000000: Unevaluated > properties are not allowed ('compatible' was unexpected) > from schema $id: > http://devicetree.org/schemas/interrupt-controller/riscv,imsics.yaml#
I'm not sure that a "Tested-by: Conor Dooley <conor.doo...@microchip.com>" here is really the right thing, given I only checked against the bindings and didn't run a guest or anything of that sort, but all of the validation issues relating to interrupt controllers are now gone. Thanks for the fixes :) Conor.
signature.asc
Description: PGP signature