On 6/4/24 01:43, Paolo Bonzini wrote:
The legacy SCSI passthrough functionality has never been enabled for
VIRTIO 1.0 and was deprecated more than four years ago.

Get rid of it---almost, because QEMU is advertising it unconditionally
for legacy virtio-blk devices.  Just parse the header and return a
nonzero status.

Signed-off-by: Paolo Bonzini<pbonz...@redhat.com>
---
  docs/about/deprecated.rst       |  10 --
  docs/about/removed-features.rst |   8 ++
  hw/block/virtio-blk.c           | 166 +++-----------------------------
  hw/core/machine.c               |   2 -
  4 files changed, 19 insertions(+), 167 deletions(-)

diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
index 40585ca7d55..4980d721cf4 100644
--- a/docs/about/deprecated.rst
+++ b/docs/about/deprecated.rst
@@ -296,16 +296,6 @@ Device options
  Emulated device options
  '''''''''''''''''''''''
-``-device virtio-blk,scsi=on|off`` (since 5.0)
-^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-
-The virtio-blk SCSI passthrough feature is a legacy VIRTIO feature.  VIRTIO 1.0
-and later do not support it because the virtio-scsi device was introduced for
-full SCSI support.  Use virtio-scsi instead when SCSI passthrough is required.
-
-Note this also applies to ``-device virtio-blk-pci,scsi=on|off``, which is an
-alias.
-
  ``-device nvme-ns,eui64-default=on|off`` (since 7.1)
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Still used by avocado/tuxrun_baselines.py:TuxRunBaselineTest.test_ppc64, and so causes a new failure.


r~

Reply via email to