> -----Original Message----- > From: David Hildenbrand [mailto:da...@redhat.com] > Sent: Tuesday, June 4, 2024 10:02 PM > To: Gonglei (Arei) <arei.gong...@huawei.com>; qemu-devel@nongnu.org > Cc: pet...@redhat.com; yu.zh...@ionos.com; mgal...@akamai.com; > elmar.ger...@ionos.com; zhengchuan <zhengch...@huawei.com>; > berra...@redhat.com; arm...@redhat.com; lizhij...@fujitsu.com; > pbonz...@redhat.com; m...@redhat.com; Xiexiangyou > <xiexiang...@huawei.com>; linux-r...@vger.kernel.org; lixiao (H) > <lixia...@huawei.com>; jinpu.w...@ionos.com; Wangjialin > <wangjiali...@huawei.com> > Subject: Re: [PATCH 1/6] migration: remove RDMA live migration temporarily > > On 04.06.24 14:14, Gonglei via wrote: > > From: Jialin Wang <wangjiali...@huawei.com> > > > > The new RDMA live migration will be introduced in the upcoming few > > commits. > > > > Signed-off-by: Jialin Wang <wangjiali...@huawei.com> > > Signed-off-by: Gonglei <arei.gong...@huawei.com> > > --- > > [...] > > > - > > - /* Avoid ram_block_discard_disable(), cannot change during migration. > */ > > - if (ram_block_discard_is_required()) { > > - error_setg(errp, "RDMA: cannot disable RAM discard"); > > - return; > > - } > > I'm particularly interested in the interaction with virtio-balloon/virtio-mem. > > Do we still have to disable discarding of RAM, and where would you do that in > the rewrite? >
Yes, we do. We didn't change the logic. Thanks for your catching. Regards, -Gonglei > -- > Cheers, > > David / dhildenb
