Philippe Mathieu-Daudé <phi...@linaro.org> writes: > On 7/6/24 13:08, Anton Johansson wrote: >> On 30/05/24, Philippe Mathieu-Daudé wrote: >>> Semihosting currently uses the TCG probe_access API. To prepare for >>> encoding the TCG dependency in Kconfig, do not enable it unless TCG >>> is available. >>> >>> Suggested-by: Paolo Bonzini <pbonz...@redhat.com> >>> Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org> >>> --- >>> target/mips/Kconfig | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >> xtensa and m68k also `select SEMIHOSTING`, were these missed? > > TCG is the only accelerator they use, so it is kinda implicit, > but you are right, I'll update for completeness.
So I'll wait for a v3? > >> Otherwise for patch 1 & 2: >> Reviewed-by: Anton Johansson <a...@rev.ng> > > Thanks! -- Alex Bennée Virtualisation Tech Lead @ Linaro
