On Tue, Jun 11, 2024 at 01:41:57PM +0300, Manos Pitsidianakis wrote: > Date: Tue, 11 Jun 2024 13:41:57 +0300 > From: Manos Pitsidianakis <manos.pitsidiana...@linaro.org> > Subject: Re: [RFC PATCH v1 0/6] Implement ARM PL011 in Rust > > > Currently, pl011 exclusively occupies a cargo as a package. In the > > future, will other Rust implementations utilize the workspace mechanism > > to act as a second package in the same cargo? Or will new cargo be created > > again? > > What do you mean by "new cargo"? I didn't catch that :( > > A workspace would make sense if we have "general" crate libraries that > hardware crates depend on.
Thanks Manos! I mean if we spread the rust device across the QEMU submodules, wouldn't we have to create their own cargo directories (aka single-package cargo) for each rust device? However, if the Rust code is all centralized under the /Rust directory, then it can be managed by multiple-packages in cargo workspace. About the "general" crate, I'm not sure whether a base lib to manage external crates is a good idea, like I replied in [1]. [1]: https://lore.kernel.org/qemu-devel/CAJSP0QWLe6yPDE3rPztx=os0g+vkt9w3gykrnu0eqzcaw06...@mail.gmail.com/T/#mfaf9abf06ed82dd7f8ce5e7520bbb4447083b550 > > > > Under a unified Rust directory, using a workspace to manage multiple > > packages looks as if it would be easier to maintain. Decentralized to an > > existing directory, they're all separate cargos, and external dependencies > > tend to become fragmented? > > Hmm potentially yes, but that's a "what if" scenario. Let's worry about that > bridge when we cross it! > Yes!
