On 6/7/24 3:16 AM, Daniel P. Berrangé wrote:
On Thu, Jun 06, 2024 at 10:02:48AM -0400, Don Porter wrote:
Please don't add new HMP commands that don't have a QMP
equivalent.
This should be adding an 'x-query-pg' QMP command, which
returns HumanReadableText, and then call that from the HMP
There is guidance on this here:
https://www.qemu.org/docs/master/devel/writing-monitor-commands.html#writing-a-debugging-aid-returning-unstructured-text
If you need more real examples, look at the various
'x-query-XXXX' commands in qapi/machine.json and
their impl.
Thank you both for the pointers. This makes sense to me;
outputting a string is much cleaner. Will implement in v4...
-dp
