Hi Daniel and Philippe
Is it ok to add the version filed to the GuestNetworkRoute struct
to indicate that this is an IPv4 or an IPv6 route or is it better to have
two
different structures?
Best Regards,
Konstantin Kostiuk.
On Wed, Jun 12, 2024 at 3:53 PM Daniel P. Berrangé <berra...@redhat.com>
wrote:
> On Wed, Jun 12, 2024 at 02:48:24PM +0200, Philippe Mathieu-Daudé wrote:
> > Hi Dehan,
> >
> > On 12/6/24 12:31, Dehan Meng wrote:
> > > The Route information of the Linux VM needs to be used
> > > by administrators and users when debugging network problems
> > > and troubleshooting.
> > >
> > > Signed-off-by: Dehan Meng <dem...@redhat.com>
> > > ---
> > > qga/commands-posix.c | 81
> ++++++++++++++++++++++++++++++++++++++++++++
> > > qga/commands-win32.c | 6 ++++
> > > qga/qapi-schema.json | 56 ++++++++++++++++++++++++++++++
> > > 3 files changed, 143 insertions(+)
> >
> >
> > > diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
> > > index b3de1fb6b3..58f51aecbb 100644
> > > --- a/qga/qapi-schema.json
> > > +++ b/qga/qapi-schema.json
> > > @@ -1800,3 +1800,59 @@
> > > { 'command': 'guest-get-cpustats',
> > > 'returns': ['GuestCpuStats']
> > > }
> > > +
> > > +##
> > > +# @GuestNetworkRoute:
> > > +#
> > > +# Route information, currently, only linux supported.
> > > +#
> > > +# @iface: The destination network or host's egress network interface
> in the routing table
> > > +#
> > > +# @destination: The IP address of the target network or host, The
> final destination of the packet
> >
> > Maybe clearer to start naming this @ipv4 in case you plan @ipv6
> > support later (see @NetdevUserOptions structure in qapi/net.json).
>
> IMHO IPv6 must be supported from the start - it really isn't acceptable
> to write new IPv4 only code today.
>
> With regards,
> Daniel
> --
> |: https://berrange.com -o-
> https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org -o-
> https://fstop138.berrange.com :|
> |: https://entangle-photo.org -o-
> https://www.instagram.com/dberrange :|
>
>
