> -----Original Message----- > From: Fabiano Rosas <faro...@suse.de> > Sent: Wednesday, June 12, 2024 10:31 PM > To: Liu, Yuan1 <yuan1....@intel.com>; pet...@redhat.com; > pbonz...@redhat.com; marcandre.lur...@redhat.com; berra...@redhat.com; > th...@redhat.com; phi...@linaro.org > Cc: qemu-devel@nongnu.org; Liu, Yuan1 <yuan1....@intel.com>; Zou, Nanhai > <nanhai....@intel.com>; shameerali.kolothum.th...@huawei.com > Subject: Re: [PATCH v8 4/7] migration/multifd: add qpl compression method > > Fabiano Rosas <faro...@suse.de> writes: > > > Yuan Liu <yuan1....@intel.com> writes: > > > >> add the Query Processing Library (QPL) compression method > >> > >> Introduce the qpl as a new multifd migration compression method, it can > >> use In-Memory Analytics Accelerator(IAA) to accelerate compression and > >> decompression, which can not only reduce network bandwidth requirement > >> but also reduce host compression and decompression CPU overhead. > >> > >> How to enable qpl compression during migration: > >> migrate_set_parameter multifd-compression qpl > >> > >> There is no qpl compression level parameter added since it only > supports > >> level one, users do not need to specify the qpl compression level. > >> > >> Signed-off-by: Yuan Liu <yuan1....@intel.com> > >> Reviewed-by: Nanhai Zou <nanhai....@intel.com> > >> Reviewed-by: Peter Xu <pet...@redhat.com> > >> Reviewed-by: Fabiano Rosas <faro...@suse.de> > > > > I don't think I ever reviewed this patch. Please drop this when you > > resubmit. > > Actually, just leave it. I thought you'd need to fix the output size on > 6/7, but I saw you just moved it elsewhere. So no need to respin. I'll > queue this version shortly unless anyone else has comments.
Got it and thank you for your review.
