On Thu, Jun 13, 2024, 4:50 AM Philippe Mathieu-Daudé <phi...@linaro.org> wrote:
> Hi John, > Hi Phil! > On 12/6/24 20:40, John Snow wrote: > > Hiya, here's some draft output of a script I'm working on to summarize > > QMP wire format differences between QEMU versions. > > > > This script works in terms of the QMP *wire format*, not the QAPI > > *specification*. As a consequence, *almost* all type names are stripped > > from this output and all nested structures are fully inlined - so > > changes to shared data structures, enums, etc will manifest as many > > independent changes. Similarly, changes to type names and type > > factorings that do not change the wire format will not appear in this > > report at all. > > Do you include changes on unstable features or are you skipping them? > > Possible feature request: skip them by default until a --unstable > CLI option is used. > In this early draft, I do include such changes. I might want to /opt-in/ to hiding them (maybe: --hide-unstable), but it can be done. (A summary mode that hides itemized changes may also be useful for observing broad-changes-at-a-glance and might be worth adding, too. --no-detail or --brief or some such.) I assume we want to hide anything that has the unstable feature flag at the command *root* and any command or event named with the x- prefix. (unstable fields on stable commands ... tbd.) I still need to implement full support for if/features, so this idea can come along for the ride when I flesh out those details. (features/if for top-level definitions are recorded, but are likely missing for various nested fields. The diff output will remark on what changed on the summary line where it says "(arguments)" or "(arguments, returns)" with the tokens "if" or "features", but it doesn't break it out into discrete elements like everything else does, yet - and it still likely only catches those differences when they occur at the definition root.) > > > > This is still a WIP: if conditionals and features may not be fully > > represented in this summary report. > > Regards, > > Phil. > Thanks for the suggestion! BTW, I sent a new mail out to the list with a link to gitlab for source and sample output for this tool and other goodies; the URL is https://gitlab.com/jsnow/externalized-qapi - see the other mail for details on what's in here, if curious. --js >
