On Thu, Jun 13, 2024 at 11:54:58AM -0300, Fabiano Rosas wrote: > Fabiano Rosas <faro...@suse.de> writes: > > > Peter Xu <pet...@redhat.com> writes: > > > >> We always do the flush when finishing one round of scan, and during > >> complete() phase we should scan one more round making sure no dirty page > >> existed. In that case we shouldn't need one explicit FLUSH at the end of > >> complete(), as when reaching there all pages should have been flushed. > >> > >> Signed-off-by: Peter Xu <pet...@redhat.com> > > > > Reviewed-by: Fabiano Rosas <faro...@suse.de> > > Actually, let's be more clear and make this a: > > Tested-by: Fabiano Rosas <faro...@suse.de> > > That way I'll remember this went through the same tests as the other > multifd sync changes we made.
Or... could I take both? :) And thanks for checking that. -- Peter Xu
