On 6/7/24 1:03 PM, Richard Henderson wrote:
On 6/6/24 07:02, Don Porter wrote:
Signed-off-by: Don Porter <por...@cs.unc.edu>
---
target/i386/cpu.h | 42 ++
target/i386/helper.c | 515 +++++++++++++++++++++++++
target/i386/tcg/sysemu/excp_helper.c | 555 +--------------------------
3 files changed, 562 insertions(+), 550 deletions(-)
Why do you want to move this code out of a tcg specific file?
I think this is definitely wrong.
I want to share the get_physical_address() code with
x86_cpu_get_phys_page_attrs_debug().
I assume that newly shared code should migrate into a common file, but
happy to adopt another strategy.
Best,
Don
