Re: [PATCH] Make TARGET_PAGE_MASK typed as target_ulong

[Richard Henderson]

On 6/14/24 12:29, Roman Kiryanov wrote:
this fixes the build warnings like
accel/tcg/cputlb.c:416:13: warning: shifting a negative signed value is 
undefined [-Wshift-negative-value]
     mask &= TARGET_PAGE_MASK | TLB_INVALID_MASK;
             ^~~~~~~~~~~~~~~~
include/exec/cpu-all.h:169:45: note: expanded from macro 'TARGET_PAGE_MASK'
                             ~~~~~~~~~~~~~~~ ^

also this fixes the inconsitency in the return
type of qemu_target_page_mask (int could be
shorter than target_long).

Signed-off-by: Roman Kiryanov <r...@google.com>

No, this will cause failures, because we need this value to sign-extend to when the 
context includes {u}int64_t, and target_ulong is uint32_t.

What options are you using, because this warning should not be generated with 
-fwrapv.


r~