On Wed, Jun 19, 2024 at 12:12:50PM +0200, Igor Mammedov wrote:
> On Fri, 24 May 2024 11:44:10 +0530
> Sunil V L <suni...@ventanamicro.com> wrote:
>
> > Add basic ACPI table test case for RISC-V.
> >
> > Signed-off-by: Sunil V L <suni...@ventanamicro.com>
> > ---
> > tests/qtest/bios-tables-test.c | 27 +++++++++++++++++++++++++++
> > 1 file changed, 27 insertions(+)
> >
> > diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> > index c73174ad00..880435a5fa 100644
> > --- a/tests/qtest/bios-tables-test.c
> > +++ b/tests/qtest/bios-tables-test.c
> > @@ -1935,6 +1935,29 @@ static void test_acpi_microvm_acpi_erst(void)
> > }
> > #endif /* CONFIG_POSIX */
> >
> > +static void test_acpi_riscv64_virt_tcg(void)
> > +{
> > + ->cd data = {
> > + .machine = "virt",
> > + .arch = "riscv64",
> > + .tcg_only = true,
> > + .uefi_fl1 = "pc-bios/edk2-riscv-code.fd",
> > + .uefi_fl2 = "pc-bios/edk2-riscv-vars.fd",
> > + .ram_start = 0x80000000ULL,
> > + .scan_len = 128ULL * 1024 * 1024,
> > + };
> > +
> > + /*
> > + * RHCT will have ISA string encoded. To reduce the effort
> > + * of updating expected AML file for any new default ISA extension,
> > + * use the profile rva22s64.
> > + */
> > + test_acpi_one("-cpu rva22s64 -device virtio-blk-device,drive=hd0 "
> > + "-drive
> > file=tests/data/uefi-boot-images/bios-tables-test.riscv64.iso.qcow2,id=hd0",
>
> Can you reuse test_data->cd, instead of specifying disk here?
>
Actually, currently there is an issue with RISC-V virt machine due to
which -cdrom doesn't work properly. But I have a fix for that. With that
fix in place , I can use cd here.
I will send that fix tomorrow separately.
Thanks,
Sunil
