Richard Henderson <richard.hender...@linaro.org> writes:

> On 6/16/24 23:28, Gustavo Romero wrote:
>> +static char *extended_qsupported_features;
>> +void gdb_extend_qsupported_features(char *qsupported_features)
>> +{
>> +    extended_qsupported_features = qsupported_features;
>> +}
>
> Assert these functions aren't called twice.
> That should be good enough until we need something more complicated.

They are called more than once (because we go through the vcpu realize
step for each vcpu). But we should assert that if set we are not
changing the feature set.

> Speaking of more complicated... do we have a plan for gdb when we get
> to the point where the board contains multiple cpu types?  Not yet, of
> course, but we're working on it...

I think gdb needs to be a little smarter here.

>
>
> r~

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro

Reply via email to