On Fri, 21 Jun 2024 at 17:24, Cord Amfmgm <dmamf...@gmail.com> wrote: > > > On Fri, Jun 21, 2024 at 10:21 AM Peter Maydell <peter.mayd...@linaro.org> > wrote: >> Thanks; I've picked up this patch for target-arm.next (as with >> your previous one for hcd-ohci, adjusting the Author and >> Signed-off-by lines to both read David Hubbard). >> >> I tweaked the commit message a little bit, so the middle part reads: >> >> What this patch does is loosen the qemu ohci implementation to allow a >> zero-length packet if td.be (Buffer End) is set to td.cbp - 1, and with a >> non-zero td.cbp value. >> >> The spec is unclear whether this is valid or not -- it is not the >> clearly documented way to send a zero length TD (which is CBP=BE=0), >> but it isn't specifically forbidden. Actual hw seems to be ok with it. > > That tweak looks great. > > Thank you for your patience working with me to get this patch into a good > shape. > > This was my first attempt to contribute to qemu - really appreciate it.
You're welcome -- thanks for the effort you've put in on your end working through our code review process. -- PMM
