On Mon, Jun 24, 2024 at 02:40:48PM +0000, Gao,Shiyuan wrote: > > > > > +static Aml *build_oshp_method(void) > > > > > +{ > > > > > + Aml *method; > > > > > + > > > > > + /* > > > > > + * Request control of SHPC hotplug via OSHP method, > > > > > + * no need parameter and return value in acpi_pcihp. > > > > > + */ > > > > > > > > Quote spec and earliest version documenting this, please. > > > > > > I cann't find document describe this, only find in the kernel code > > > and describe it in the commit message. > > > > Hrrm you really should read the spec not just go by the fact things > > happen to work. Look up PCI Firmware Specification > > > Thanks and I will quote it.
yes and also pls explain why does an empty method make sense from spec POV.