Hi all! This series presents a new command blockdev-replace, which helps to insert/remove filters anywhere in the block graph. It can:
- replace qdev block-node by qdev-id - replace export block-node by export-id - replace any child of parent block-node by node-name and child name So insertions is done in two steps: 1. blockdev_add (create filter node, unparented) [some parent] [new filter] | | V V [ some child ] 2. blockdev-replace (replace child by the filter) [some parent] | V [new filter] | V [some child] And removal is done in reverse order: 1. blockdev-replace (go back to picture 1) 2. blockdev_del (remove filter node) Ideally, we to do both operations (add + replace or replace + del) in a transaction, but that would be another series. v9: rebase drop x- prefix and use unstable feature bump version to 9.1 in qapi spec update error message in blk_by_qdev_id stub v8: rebase. Also don't use "preallocate" filter in a test, as we don't support removal of this filter for now. Preallocate filter is really unusual, see discussion here: https://www.mail-archive.com/qemu-devel@nongnu.org/msg994945.html Vladimir Sementsov-Ogievskiy (7): block-backend: blk_root(): drop const specifier on return type block/export: add blk_by_export_id() block: make bdrv_find_child() function public qapi: add blockdev-replace command block: bdrv_get_xdbg_block_graph(): report export ids iotests.py: introduce VM.assert_edges_list() method iotests: add filter-insertion block.c | 17 ++ block/block-backend.c | 2 +- block/export/export.c | 31 +++ blockdev.c | 70 ++++-- include/block/block_int-io.h | 2 + include/block/export.h | 1 + include/sysemu/block-backend-global-state.h | 3 +- qapi/block-core.json | 88 +++++++ stubs/blk-by-qdev-id.c | 13 + stubs/blk-exp-find-by-blk.c | 9 + stubs/meson.build | 2 + tests/qemu-iotests/iotests.py | 17 ++ tests/qemu-iotests/tests/filter-insertion | 236 ++++++++++++++++++ tests/qemu-iotests/tests/filter-insertion.out | 5 + 14 files changed, 480 insertions(+), 16 deletions(-) create mode 100644 stubs/blk-by-qdev-id.c create mode 100644 stubs/blk-exp-find-by-blk.c create mode 100755 tests/qemu-iotests/tests/filter-insertion create mode 100644 tests/qemu-iotests/tests/filter-insertion.out -- 2.34.1