Hi Julien, On Fri, May 24, 2024 at 06:22:12PM +0100, Julien Grall wrote: > Hi Mostafa, > > On 29/04/2024 04:24, Mostafa Saleh wrote: > > Use the new SMMU property to make the SMMU OAS match the CPU PARANGE. > > That's according to SMMU manual ARM IHI 0070F.b: > 6.3.6 SMMU_IDR5, > > OAS must match the system physical address size. > > > > > Signed-off-by: Mostafa Saleh <smost...@google.com> > > --- > > hw/arm/virt.c | 14 ++++++++++++-- > > target/arm/cpu.h | 2 ++ > > target/arm/cpu64.c | 5 +++++ > > When trying to build qemu-system-arm, I get the following error: > > [1/3028] Generating subprojects/dtc/version_gen.h with a custom command > [2/3028] Generating qemu-version.h with a custom command (wrapped by meson > to capture output) > [3/3021] Linking target qemu-system-aarch64 > [4/3021] Linking target qemu-system-arm > FAILED: qemu-system-arm > clang -m64 -mcx16 @qemu-system-arm.rsp > libqemu-arm-softmmu.fa.p/hw_arm_virt.c.o: In function `get_system_oas': > /home/jgrall/works/oss/qemu/build/../hw/arm/virt.c:259: undefined reference > to `cpu_arm_get_oas' > clang-11: error: linker command failed with exit code 1 (use -v to see > invocation) > ninja: build stopped: subcommand failed. > make: *** [run-ninja] Error 1 > > I think you need to provide cpu_arm_get_oas() also for 32-bit arm (I guess > it is implemented in target/arm/cpu.c). > Ouch, thanks for testing that, I am currently reworking this and migh drop this change as Eric suggested, but I will make sure it also builds for arm.
Thanks, Mostafa > Cheers, > > -- > Julien Grall
