I have no issues with these APIs, but I'm not a QMP expert so others should review those bits.
For the vhost-user-blk code: Acked-by: Raphael Norwitz <raph...@enfabrica.net> On Tue, Jun 25, 2024 at 8:19 AM Vladimir Sementsov-Ogievskiy <vsement...@yandex-team.ru> wrote: > > v5: > 03: drop extra check on is is runstate running > > > Vladimir Sementsov-Ogievskiy (3): > qdev-monitor: add option to report GenericError from find_device_state > vhost-user-blk: split vhost_user_blk_sync_config() > qapi: introduce device-sync-config > > hw/block/vhost-user-blk.c | 27 ++++++++++++++------ > hw/virtio/virtio-pci.c | 9 +++++++ > include/hw/qdev-core.h | 3 +++ > qapi/qdev.json | 24 ++++++++++++++++++ > system/qdev-monitor.c | 53 ++++++++++++++++++++++++++++++++++++--- > 5 files changed, 105 insertions(+), 11 deletions(-) > > -- > 2.34.1 >
