On 7/2/24 08:58, Alex Bennée wrote:
Richard Henderson <richard.hender...@linaro.org> writes:
In a completely artifical memset benchmark object_dynamic_cast_assert
dominates the profile, even above guest address resolution and
the underlying host memset.
We seem to use ARM_CPU() quite liberally for a number of helpers so I
wonder if its worth codifying this anywhere? At least all the direct TCG
op helpers take CPUARMState *env directly.
For things that are akin to virtual method calls, i.e. the function pointer comes from a
table within the object or class, I think we can trust the lookup. Therefore no dynamic
check required on entry to those functions.
That said, cpu_env() is relatively new and we haven't made a concerted effort to use it
everywhere that it might make sense.
r~
