On 3/7/24 16:06, Marcin Juszkiewicz wrote:
We changed sbsa-ref cpu several times already and may do it again in a
future. To newer core or to enable/disable some properties.
This change switches Neoverse-N2 tests to 'let test default cpu' ones.
Signed-off-by: Marcin Juszkiewicz <marcin.juszkiew...@linaro.org>
---
tests/avocado/machine_aarch64_sbsaref.py | 29 ++++++++++++++++-------------
1 file changed, 16 insertions(+), 13 deletions(-)
diff --git a/tests/avocado/machine_aarch64_sbsaref.py
b/tests/avocado/machine_aarch64_sbsaref.py
index 2e27d37cb8..46a1d982f3 100644
--- a/tests/avocado/machine_aarch64_sbsaref.py
+++ b/tests/avocado/machine_aarch64_sbsaref.py
@@ -113,7 +113,7 @@ def test_sbsaref_edk2_firmware(self):
# This tests the whole boot chain from EFI to Userspace
# We only boot a whole OS for the current top level CPU and GIC
# Other test profiles should use more minimal boots
- def boot_alpine_linux(self, cpu):
+ def boot_alpine_linux(self, cpu=False):
self.fetch_firmware()
iso_url = (
@@ -126,12 +126,14 @@ def boot_alpine_linux(self, cpu):
self.vm.set_console()
self.vm.add_args(
- "-cpu",
- cpu,
"-drive",
f"file={iso_path},format=raw",
)
+ # let allow test which will use default cpu of platform
+ if cpu:
+ self.vm.add_args("-cpu", cpu)
I think the pythonic way is to initialize cpu=None instead of False.
+
self.vm.launch()
wait_for_console_pattern(self, "Welcome to Alpine Linux 3.17")
