On Thu May 23, 2024 at 3:14 PM AEST, Harsh Prateek Bora wrote: > The second if-condition can be true only if the first one above is true. > Enclose the latter into the former to avoid un-necessary check if first > condition fails. > > Signed-off-by: Harsh Prateek Bora <hars...@linux.ibm.com> > Reviewed-by: BALATON Zoltan <bala...@eik.bme.hu>
Ditto for this it's possible compiler can transform it, but I like the code. Reviewed-by: Nicholas Piggin <npig...@gmail.com> > --- > target/ppc/helper_regs.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/target/ppc/helper_regs.c b/target/ppc/helper_regs.c > index d09dcacd5e..261a8ba79f 100644 > --- a/target/ppc/helper_regs.c > +++ b/target/ppc/helper_regs.c > @@ -66,9 +66,9 @@ static uint32_t hreg_compute_pmu_hflags_value(CPUPPCState > *env) > #ifndef CONFIG_USER_ONLY > if (env->pmc_ins_cnt) { > hflags |= 1 << HFLAGS_INSN_CNT; > - } > - if (env->pmc_ins_cnt & 0x1e) { > - hflags |= 1 << HFLAGS_PMC_OTHER; > + if (env->pmc_ins_cnt & 0x1e) { > + hflags |= 1 << HFLAGS_PMC_OTHER; > + } > } > #endif > #endif