On Sat, Jul 6, 2024 at 7:26 AM Daniel Henrique Barboza <dbarb...@ventanamicro.com> wrote: > > Hi, > > Would it make it easier for review if we squash patch 3: > > [PATCH v4 03/14] hw/riscv: add RISC-V IOMMU base emulation > > and patch 8: > > [PATCH v4 09/14] hw/riscv/riscv-iommu: add s-stage and g-stage support > > In the same patch? > > I'm asking because I've been noticing since the first versions that some > reviews > on patch 3 seems to refer to context that are s-stage and g-stage related, > i.e. > added later. Perhaps squashing them together makes it easier to review since > we'll have a more complete picture. Patch 3 will end up gaining +381 lines > though.
Squashing is probably the way to go Alistair
