John Snow <js...@redhat.com> writes: > On Sat, Jul 6, 2024, 10:47 AM Markus Armbruster <arm...@redhat.com> wrote: > >> John Snow <js...@redhat.com> writes: >> >> > Factor out the compatibility parser helper into a base class, so it can >> > be shared by other directives. >> > >> > Signed-off-by: John Snow <js...@redhat.com> >> >> R-by stands. > > Assuming true even if I rebase on top of the 3.x patches and do_parse() > becomes quite a bit more trivial?
If you think the changes don't warrant a fresh review, keep my R-by. You may get one anyway ;)