On Fri, Jul 12, 2024 at 12:05:23PM +0300, Konstantin Kostiuk wrote: > On Thu, Jun 13, 2024 at 6:45 PM Daniel P. Berrangé <berra...@redhat.com> > wrote: > > > Allowing the user to set the QGA_CONF environment variable to change > > the default configuration file path is very unusual practice, made > > more obscure since this ability is not documented. > > > > This introduces the more normal '-c PATH' / '--config=PATH' command > > line argument approach. This requires that we parse the comamnd line > > twice, since we want the command line arguments to take priority over > > the configuration file settings in general. > > > > Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> > > --- > > docs/interop/qemu-ga.rst | 5 +++++ > > qga/main.c | 35 +++++++++++++++++++++++++++-------- > > 2 files changed, 32 insertions(+), 8 deletions(-) > > > > diff --git a/docs/interop/qemu-ga.rst b/docs/interop/qemu-ga.rst > > index 72fb75a6f5..e42b370319 100644 > > --- a/docs/interop/qemu-ga.rst > > +++ b/docs/interop/qemu-ga.rst > > @@ -33,6 +33,11 @@ Options > > > > .. program:: qemu-ga > > > > +.. option:: -c, --config=PATH > > + > > + Configuration file path (the default is |CONFDIR|\ ``/qemu-ga.conf``, > > + unless overriden by the QGA_CONF environment variable) > > + > > .. option:: -m, --method=METHOD > > > > Please also update qga/main.c static void usage(const char *cmd)
Opps, yes, will do. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
