Yichen Wang <yichen.w...@bytedance.com> writes: > v5 > * Rebase on top of 39a032cea23e522268519d89bb738974bc43b6f6. > * Rename struct definitions with typedef and CamelCase names; > * Add build and runtime checks about DSA accelerator; > * Address all comments from v4 reviews about typos, licenses, comments, > error reporting, etc.
Hi, You forgot to make sure the patches compile without DSA support as well! =) Also, please be more explicit on the state of the series, the WIP on the title is not enough. You can send the whole series as RFC (e.g. PATCH RFC v5) if it's not ready to merge, or put the RFC tag only on the patches you need help with. But make sure you have some words in the cover-letter stating what is going on. Another point is, I see you have applied some suggestions from the previous version, but did those on top of the existing code in some cases. Try to avoid that and please fix it for the next version. That is, don't add code in one patch just to remove it on the next, try to apply the changes/suggestions on the patch that introduces the code, as much as possible.
