On Wed, 17 Jul 2024 at 15:20, Marc-André Lureau <marcandre.lur...@gmail.com> wrote:
> Hi > > On Wed, Jul 17, 2024 at 5:11 PM Phil Dennis-Jordan <p...@philjordan.eu> > wrote: > >> >> Mouse cursors with 8 bit alpha were downsampled to 1-bit opacity maps by >>>> turning alpha values of 255 into 1 and everything else into 0. This >>>> means that mostly-opaque pixels ended up completely invisible. >>>> >>>> This patch changes the behaviour so that only pixels with less than 50% >>>> alpha (0-127) are treated as transparent when converted to 1-bit alpha. >>>> >>>> This greatly improves the subjective appearance of anti-aliased mouse >>>> cursors, such as those used by macOS, when using a front-end UI without >>>> support for alpha-blended cursors, such as some VNC clients. >>>> >>>> Signed-off-by: Phil Dennis-Jordan <p...@philjordan.eu> >>>> >>> >>> Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com> >>> >> >> Reviewed-by: Akihiko Odaki <akihiko.od...@daynix.com> >> >> >> Thanks for the reviews folks! Is there anything I can do to move this >> forward? Should I submit a v3 with the review tags included? The patch >> continues to apply cleanly so it didn't seem necessary, but I admit I'm >> still not 100% clear on whom I should badger (?) to get favourably received >> patches actually pulled into staging/master. >> >> https://patchew.org/QEMU/20240624101040.82726-1-p...@philjordan.eu/ >> >> > I'll include it in a UI-related PR. > > thanks > Thank you!
