On 17/07/2024 14:34, Eric Auger wrote: > On 7/17/24 14:41, Joao Martins wrote: >> On 17/07/2024 13:36, Eric Auger wrote: >>> On 7/12/24 13:47, Joao Martins wrote: >>>> The checking of hwpt::flags is introduced here as a second user >>> ?? -> introduce iommufd_hwpt_dirty_tracking() helper to avoid code dup? >> Right I am doing that already. Not sure what the problem is with this >> sentence? > > "The checking of hwpt::flags is introduced here as a second user" phrasing > sounds weird to me. > I guess you just meant that you need to check > hwpt::flags in another place so better off introducing an helper. >
Exactly.
