Am 18.07.2024 um 14:36 hat Markus Armbruster geschrieben: > BlockdevSnapshotInternal is the arguments type of command > blockdev-snapshot-internal-sync. Its doc comment contains this note: > > # .. note:: In a transaction, if @name is empty or any snapshot matching > # @name exists, the operation will fail. Only some image formats > # support it; for example, qcow2, and rbd. > > "In a transaction" is misleading, and "if @name is empty or any > snapshot matching @name exists, the operation will fail" is redundant > with the command's Errors documentation. Drop. > > The remainder is fine. Move it to the command's doc comment, where it > is more prominently visible, with a slight rephrasing for clarity. > > Signed-off-by: Markus Armbruster <arm...@redhat.com>
Thanks, applied to the block branch. Kevin
