Vladimir Sementsov-Ogievskiy <vsement...@yandex-team.ru> writes: > On 18.07.24 11:27, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy <vsement...@yandex-team.ru> writes: >> >>> Add command to sync config from vhost-user backend to the device. It >>> may be helpful when VHOST_USER_SLAVE_CONFIG_CHANGE_MSG failed or not >>> triggered interrupt to the guest or just not available (not supported >>> by vhost-user server). >>> >>> Command result is racy if allow it during migration. Let's allow the >>> sync only in RUNNING state. >> >> Is this still accurate? The runstate_is_running() check is gone in >> v4, the migration_is_running() check remains. > > Right, better to fix commit message like: > > Command result is racy if allow it during migration. Let's not allow it.
Suggest "Let's not allow that." Thanks! >>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@yandex-team.ru> >> >> QAPI schema and QMP part: >> Signed-off-by: Markus Armbruster <arm...@redhat.com>
