Am 03.04.2012 10:38, schrieb Lai Jiangshan: > queues are not just internal things for locks, split them. > > Signed-off-by: Lai Jiangshan <la...@cn.fujitsu.com> > --- > Makefile.objs | 2 +- > qemu-coroutine-lock.c | 49 +------------------------------ > qemu-coroutine-queue.c | 76 > ++++++++++++++++++++++++++++++++++++++++++++++++ > trace-events | 4 ++- > 4 files changed, 81 insertions(+), 50 deletions(-)
What's the point? qemu-coroutine-lock.c is already a small file (171 lines) and all functions in it are doing related things (they synchronise coroutines). Splitting a small cohesive file into two tiny halves isn't an improvement, IMO. Kevin
