On 26.07.24 22:00, Collin Walling wrote:
On 7/26/24 3:57 PM, David Hildenbrand wrote:
On 25.07.24 20:39, Collin Walling wrote:
Currently, there is no way to execute the query-cpu-model-expansion
command to retrieve a comprehenisve list of deprecated properties, as
the result is dependent per-model. To enable this, the expansion output
is modified as such:
When reporting a "static" CPU model, the command will only show
deprecated properties that are a subset of the model's *enabled*
properties. This is more accurate than how the query was handled
before, which blindly reported properties that were never introduced
for certain models.
When reporting a "full" CPU model, show the *entire* list of deprecated
properties regardless if they are supported on the model. A full
expansion outputs all known CPU model properties anyway, so it makes
sense to report all deprecated properties here too. This allows
management apps to query a single model (e.g. host) to acquire the
full list of deprecated properties.
Additionally, the @deprecated-props array has been moved from the
CpuModelInfo struct to the CpuModelExpansionInfo struct, since the data
did not belong in the former.
Acked-by: David Hildenbrand <da...@redhat.com>
Suggested-by: Jiri Denemark <jdene...@redhat.com>
Signed-off-by: Collin Walling <wall...@linux.ibm.com>
---
Hmmm, this does not apply on current master ... maybe because Thomas
already merged part of it?
Uh oh, sorry about that. I'll fix this right now and post a v5 with a
corrected rebase on master.
It would be great if the changelog could then only describe the diff to
already-merged:
commit da5cd572710cc4ad7e2c653614a4ab1598b17e78
Author: Collin L. Walling <wall...@linux.ibm.com>
Date: Thu Jul 25 14:39:09 2024 -0400
target/s390x: filter deprecated properties based on model expansion type
Currently, there is no way to execute the query-cpu-model-expansion
command to retrieve a comprehenisve list of deprecated properties, as
the result is dependent per-model. To enable this, the expansion output
is modified as such:
When reporting a "static" CPU model, the command will only show
deprecated properties that are a subset of the model's *enabled*
properties. This is more accurate than how the query was handled
before, which blindly reported properties that were never introduced
for certain models.
When reporting a "full" CPU model, show the *entire* list of deprecated
properties regardless if they are supported on the model. A full
expansion outputs all known CPU model properties anyway, so it makes
sense to report all deprecated properties here too. This allows
management apps to query a single model (e.g. host) to acquire the
full list of deprecated properties.
Additionally, the @deprecated-props array has been moved from the
CpuModelInfo struct to the CpuModelExpansionInfo struct, since the data
did not belong in the former.
--
Cheers,
David / dhildenb
