On Fri, Aug 02, 2024 at 04:57:13PM +0100, Roy Hopkins wrote: > On Wed, 2024-07-24 at 17:29 +0100, Daniel P. Berrangé wrote: > > On Wed, Jul 03, 2024 at 12:05:38PM +0100, Roy Hopkins wrote: > > > Here is v4 of the set of patches to add support for IGVM files to QEMU. > > > This > > > is > > > based on commit 1a2d52c7fc of qemu. > > > > > > This version addresses all of the review comments from v3 along with a > > > couple of > > > small bug fixes. This is a much smaller increment than in the previous > > > version > > > of the series [1]. Thanks once again to the reviewers that have been > > > looking > > > at > > > this series. This v4 patch series is also available on github: [2] > > > > > > The previous version had a build issue when building without debug > > > enabled. > > > Patch 8/17 has been added to fix this and I've updated my own process to > > > test > > > both debug and release builds of QEMU. > > > > > > For testing IGVM support in QEMU you need to generate an IGVM file that is > > > configured for the platform you want to launch. You can use the > > > `buildigvm` > > > test tool [3] to allow generation of IGVM files for all currently > > > supported > > > platforms. Patch 11/17 contains information on how to generate an IGVM > > > file > > > using this tool. > > > > Am I right that, currently, we can only use this IGVM support for plain > > SEV/SNP boot *without* SVSM ? I'm told SVSM has a dependency on host > > kernel KVM features not yet upstream, and I presume this means also needs > > further QEMU patches ? > > Yes, you are right in that the host kernel does not yet support SVSM. However, > I've tried to ensure that the IGVM implementation in QEMU will not require any > further patches when SVSM support arrives in the kernel. > > This obviously cannot be guaranteed as it is not clear exactly what the SVSM > support will look like, but as an example, take a look at > https://github.com/coconut-svsm/linux/pull/6 which is a kernel branch that > contains patches to support hosting COCONUT-SVSM which works with this QEMU > IGVM > patch series at V4.
Ah good, I was getting worried for a minute thinking QEMU might need to do extra KVM ioctl setup tasks to make it work. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
