On Fri, 2 Aug 2024 23:44:01 +0200
Mauro Carvalho Chehab <mchehab+hua...@kernel.org> wrote:
> Provide a generic interface for error injection via GHESv2.
>
> This patch is co-authored:
> - original ghes logic to inject a simple ARM record by Shiju Jose;
> - generic logic to handle block addresses by Jonathan Cameron;
> - generic GHESv2 error inject by Mauro Carvalho Chehab;
>
> Co-authored-by: Jonathan Cameron <jonathan.came...@huawei.com>
> Co-authored-by: Shiju Jose <shiju.j...@huawei.com>
> Co-authored-by: Mauro Carvalho Chehab <mchehab+hua...@kernel.org>
> Cc: Jonathan Cameron <jonathan.came...@huawei.com>
> Cc: Shiju Jose <shiju.j...@huawei.com>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+hua...@kernel.org>
Looks fine to me.
Feel free to put in my SoB on the resulting co-auth
Signed-off-by: Jonathan Cameron <jonathan.came...@huawei.com>
if appropriate? Does this work same as kernel co-developed-by?
> +void ghes_record_cper_errors(AcpiGhesCper *cper, Error **errp,
> + uint32_t notify)
> +{
> + int read_ack = 0;
> + uint32_t i;
> + uint64_t read_ack_addr = 0;
> + uint64_t error_block_addr = 0;
> + uint32_t data_length;
> + GArray *block;
> +
> + if (!ghes_get_addr(notify, &error_block_addr, &read_ack_addr)) {
> + error_setg(errp, "GHES: Invalid error block/ack address(es)");
> + return;
> + }
> +
> + cpu_physical_memory_read(read_ack_addr,
> + &read_ack, sizeof(uint64_t));
> +
> + /* zero means OSPM does not acknowledge the error */
> + if (!read_ack) {
> + error_setg(errp,
> + "Last CPER record was not acknowledged yet");
> + read_ack = 1;
> + cpu_physical_memory_write(read_ack_addr,
> + &read_ack, sizeof(uint64_t));
> + return;
> + }
> +
> + read_ack = cpu_to_le64(0);
> + cpu_physical_memory_write(read_ack_addr,
> + &read_ack, sizeof(uint64_t));
> +
> + /* Build CPER record */
> +
> + /*
> + * Invalid fru id: ACPI 4.0: 17.3.2.6.1 Generic Error Data,
> + * Table 17-13 Generic Error Data Entry
> + */
> + QemuUUID fru_id = {};
> +
> + block = g_array_new(false, true /* clear */, 1);
> + data_length = ACPI_GHES_DATA_LENGTH + cper->data_len;
> +
> + /*
Odd formatting.
> + * It should not run out of the preallocated memory if
> + * adding a new generic error data entry
> + */
> + assert((data_length + ACPI_GHES_GESB_SIZE) <=
> + ACPI_GHES_MAX_RAW_DATA_LENGTH);
> +
> + /* Build the new generic error status block header */
> + acpi_ghes_generic_error_status(block, ACPI_GEBS_UNCORRECTABLE,
> + 0, 0, data_length,
> + ACPI_CPER_SEV_RECOVERABLE);
> +
> + /* Build this new generic error data entry header */
> + acpi_ghes_generic_error_data(block, cper->guid,
> + ACPI_CPER_SEV_RECOVERABLE, 0, 0,
> + cper->data_len, fru_id, 0);
> +
> + /* Add CPER data */
> + for (i = 0; i < cper->data_len; i++) {
> + build_append_int_noprefix(block, cper->data[i], 1);
> + }
> +
> + /* Write the generic error data entry into guest memory */
> + cpu_physical_memory_write(error_block_addr, block->data, block->len);
> +
> + g_array_free(block, true);
> +
> + notifier_list_notify(&generic_error_notifiers, NULL);
> +}
> +
> bool acpi_ghes_present(void)
> {
> AcpiGedState *acpi_ged_state;
