Em Mon, 5 Aug 2024 17:54:00 +0100 Jonathan Cameron <jonathan.came...@huawei.com> escreveu:
> On Fri, 2 Aug 2024 23:43:58 +0200 > Mauro Carvalho Chehab <mchehab+hua...@kernel.org> wrote: > > Do we need to rename this now there is a GED involved? > Is it even technically a GPIO any more? > Spec says in 18.3.2.7 > HW-reduced ACPI platforms signal the error using a GPIO > interrupt or another interrupt declared under > a generic event device (Interrupt-signaled ACPI events) > and goes on to say that a _CRS entry is used to > list the interrupt. > > Give the Generic Event Device has a _CRS > with aml_interrupt() as the type I think we should > even have the hest entry say it's an interrupt (external?) > rather than a gpio. True. I'll change patch description to: arm/virt: Wire up a GED error device for ACPI / GHES Adds support to ARM virtualization to allow handling a General Purpose Event (GPE) via GED error device. It is aligned with Linux Kernel patch: https://lore.kernel.org/lkml/1272350481-27951-8-git-send-email-ying.hu...@intel.com/ As the spec at https://uefi.org/specs/ACPI/6.5/18_Platform_Error_Interfaces.html#event-notification-for-generic-error-sources revers to it as: "The implementation of Event notification requires the platform to define a device with PNP ID PNP0C33 in the ACPI namespace, referred to as the error device." > > Adds support to ARM virtualization to allow handling > > a General Purpose Event (GPE) via GED error device. > > > > It is aligned with Linux Kernel patch: > > https://lore.kernel.org/lkml/1272350481-27951-8-git-send-email-ying.hu...@intel.com/ > > > > Co-authored-by: Mauro Carvalho Chehab <mchehab+hua...@kernel.org> > > Co-authored-by: Jonathan Cameron <jonathan.came...@huawei.com> > > Cc: Jonathan Cameron <jonathan.came...@huawei.com> > > Again, more or less fine with this > Signed-off-by: Jonathan Cameron <jonathan.came...@huawei.com> > to go with that co-auth Thanks! Mauro