On Tue, 6 Aug 2024 08:09:28 +0200
Mauro Carvalho Chehab <mchehab+hua...@kernel.org> wrote:
> Em Mon, 5 Aug 2024 17:56:17 +0100
> Jonathan Cameron <jonathan.came...@huawei.com> escreveu:
>
> > On Fri, 2 Aug 2024 23:43:59 +0200
> > Mauro Carvalho Chehab <mchehab+hua...@kernel.org> wrote:
> >
> > > From: Jonathan Cameron <jonathan.came...@huawei.com>
> > >
> > > Add error notification to GHES v2 using the GPIO source.
> >
> > The gpio / external interrupt follows through.
>
> True. As session 18.3.2.7 of the spec says:
>
> The OSPM evaluates the control method associated with this event
> as indicated in The Event Method for Handling GPIO Signaled Events
> and The Event Method for Handling Interrupt Signaled Events.
>
> E. g. defining two methods:
> - GED GPIO;
> - GED interrupt
>
> I'm doing this rename:
>
> ACPI_HEST_SRC_ID_GPIO -> ACPI_HEST_SRC_ID_GED_INT
>
> To clearly state what it is implemented there.
>
> I'm also changing patch description to:
>
> acpi/ghes: Add support for General Purpose Event
>
> As a GED error device is now defined, add another type
> of notification.
>
> Add error notification to GHES v2 using the GPIO source.
^^^^
did you mean: GED?
>
> [mchehab: do some cleanups at ACPI_HEST_SRC_ID_* checks and
> rename HEST event to better identify GED interrupt OSPM]
>
> Signed-off-by: Jonathan Cameron <jonathan.came...@huawei.com>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+hua...@kernel.org>
>
> Regards,
> Mauro
>
