On Fri, 16 Aug 2024 07:53:24 +0200 Mauro Carvalho Chehab <mchehab+hua...@kernel.org> wrote:
> Em Wed, 14 Aug 2024 13:33:21 +0100 > Jonathan Cameron <jonathan.came...@huawei.com> escreveu: > > > On Wed, 14 Aug 2024 01:23:23 +0200 > > Mauro Carvalho Chehab <mchehab+hua...@kernel.org> wrote: > > > > > Adds a generic error device to handle generic hardware error > > > events as specified at ACPI 6.5 specification at 18.3.2.7.2: > > > https://uefi.org/specs/ACPI/6.5/18_Platform_Error_Interfaces.html#event-notification-for-generic-error-sources > > > using HID PNP0C33. > > > > > > The PNP0C33 device is used to report hardware errors to > > > the guest via ACPI APEI Generic Hardware Error Source (GHES). > > > > > > Co-authored-by: Mauro Carvalho Chehab <mchehab+hua...@kernel.org> > > > Co-authored-by: Jonathan Cameron <jonathan.came...@huawei.com> > > > Signed-off-by: Jonathan Cameron <jonathan.came...@huawei.com> > > > Signed-off-by: Mauro Carvalho Chehab <mchehab+hua...@kernel.org> > > > Reviewed-by: Igor Mammedov <imamm...@redhat.com> > > > --- > > > hw/acpi/aml-build.c | 10 ++++++++++ > > > hw/acpi/generic_event_device.c | 8 ++++++++ > > > include/hw/acpi/acpi_dev_interface.h | 1 + > > > include/hw/acpi/aml-build.h | 2 ++ > > > include/hw/acpi/generic_event_device.h | 1 + > > > 5 files changed, 22 insertions(+) > > > > > > diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c > > > index 6d4517cfbe3d..cb167523859f 100644 > > > --- a/hw/acpi/aml-build.c > > > +++ b/hw/acpi/aml-build.c > > > @@ -2520,3 +2520,13 @@ Aml *aml_i2c_serial_bus_device(uint16_t address, > > > const char *resource_source) > > > > > > return var; > > > } > > > + > > > +/* ACPI 5.0: 18.3.2.6.2 Event Notification For Generic Error Sources */ > > > > > > > Given this section got a rename maybe the comment should mention old > > name and current name for the section? > > ACPI 6.5 has the same name for the section: We did a bit of digging after an offline discussion. It's only there in Errata B of ACPI 5.0. So need to update this reference to be more specific if we want to avoid confusion. > > 18.3.2.7.2. Event Notification For Generic Error Sources > > An event notification is recommended for corrected errors where latency > in processing error reports is not critical to proper system operation. > The implementation of Event notification requires the platform to define > a device with PNP ID PNP0C33 in the ACPI namespace, referred to as the > error device. > > Just section number changed. IMO, it is still good enough to seek for > it at the docs. > > Btw, in this specific case, the best is to use the search box of > Sphinx html output and seek for PNP0C33 ;-) > > > > > > +Aml *aml_error_device(void) > > > +{ > > > + Aml *dev = aml_device(ACPI_APEI_ERROR_DEVICE); > > > + aml_append(dev, aml_name_decl("_HID", aml_string("PNP0C33"))); > > > + aml_append(dev, aml_name_decl("_UID", aml_int(0))); > > > + > > > + return dev; > > > +} > > > diff --git a/hw/acpi/generic_event_device.c > > > b/hw/acpi/generic_event_device.c > > > index 15b4c3ebbf24..1673e9695be3 100644 > > > --- a/hw/acpi/generic_event_device.c > > > +++ b/hw/acpi/generic_event_device.c > > > @@ -26,6 +26,7 @@ static const uint32_t ged_supported_events[] = { > > > ACPI_GED_PWR_DOWN_EVT, > > > ACPI_GED_NVDIMM_HOTPLUG_EVT, > > > ACPI_GED_CPU_HOTPLUG_EVT, > > > + ACPI_GED_ERROR_EVT > > > > trailing comma missing. > > I'll add. > > Thanks, > Mauro
