Peter Maydell <peter.mayd...@linaro.org> writes: > On Tue, 27 Aug 2024 at 15:03, Fabiano Rosas <faro...@suse.de> wrote: >> >> Thomas Huth <th...@redhat.com> writes: >> >> > On 26/08/2024 17.26, Peter Xu wrote: >> >> On Fri, Aug 23, 2024 at 03:13:12PM +0900, Akihiko Odaki wrote: >> >>> A test run may create boot files several times. Delete the previous boot >> >>> file before creating a new one. >> >>> >> >>> Signed-off-by: Akihiko Odaki <akihiko.od...@daynix.com> >> >>> Reviewed-by: Michael S. Tsirkin <m...@redhat.com> >> >>> Acked-by: Thomas Huth <th...@redhat.com> >> >> >> >> I didn't track which came early, but I think Fabiano has queued the other >> >> one here: >> >> >> >> https://lore.kernel.org/r/20240820144912.320744-2-peter.mayd...@linaro.org >> >> https://gitlab.com/farosas/qemu/-/commits/migration-staging/ >> >> >> >> So we should be good. >> > >> > Ooops, sorry, I think I might have jumped the gun and put this patch here >> > in >> > my final PR for 9.1 ... I hope it's ok to do modifications on top of that >> > later if it is still necessary. >> >> It's fine, don't worry. I'll just drop the other one, they're basically >> the same. > > They're not quite the same -- my one also fixes the bug > where if we run no tests we call bootfile_delete() > without ever having called bootfile_create() and as > a result try to unlink(NULL). So if we take Akihiko's > patch I'll respin my patch to be just that fix.
Ah right, there's the other call at the end of main(). I can touch that up in migration-staging if it comes to it. > > thanks > -- PMM
