Re: [PATCH v10 02/21] linux-user/riscv: set priv for qemu-user and defaults for *envcfg

[Alistair Francis]

On Wed, Aug 28, 2024 at 9:20 AM Deepak Gupta <de...@rivosinc.com> wrote:
>
> set priv to be PRV_U for qemu-user on riscv. And set default value for
> *envcfg CSR.
>
> Signed-off-by: Deepak Gupta <de...@rivosinc.com>

You can probably just squash this with the previous patch

> ---
>  linux-user/riscv/cpu_loop.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/linux-user/riscv/cpu_loop.c b/linux-user/riscv/cpu_loop.c
> index 52c49c2e42..7a68e8717b 100644
> --- a/linux-user/riscv/cpu_loop.c
> +++ b/linux-user/riscv/cpu_loop.c
> @@ -32,6 +32,10 @@ void cpu_loop(CPURISCVState *env)
>      int trapnr;
>      target_ulong ret;
>
> +    env->priv = PRV_U;
> +    env->senvcfg = 0;
> +    env->menvcfg = 0;

I don't think this is the right place.

This should be handled by a CPU reset, which is still called for linux
user mode.

Alistair

> +
>      for (;;) {
>          cpu_exec_start(cs);
>          trapnr = cpu_exec(cs);
> --
> 2.44.0
>
>