Re: [PATCH 34/39] target/riscv: remove break after g_assert_not_reached()

[Richard Henderson]

On 9/10/24 15:16, Pierrick Bouvier wrote:

Signed-off-by: Pierrick Bouvier <pierrick.bouv...@linaro.org>
---
  target/riscv/monitor.c                  | 1 -
  target/riscv/insn_trans/trans_rvv.c.inc | 2 --
  2 files changed, 3 deletions(-)

diff --git a/target/riscv/monitor.c b/target/riscv/monitor.c
index f5b1ffe6c3e..100005ea4e9 100644
--- a/target/riscv/monitor.c
+++ b/target/riscv/monitor.c
@@ -184,7 +184,6 @@ static void mem_info_svxx(Monitor *mon, CPUArchState *env)
          break;
      default:
          g_assert_not_reached();
-        break;
      }

/* calculate virtual address bits */

diff --git a/target/riscv/insn_trans/trans_rvv.c.inc 
b/target/riscv/insn_trans/trans_rvv.c.inc
index 3a3896ba06c..f8928c44a8b 100644
--- a/target/riscv/insn_trans/trans_rvv.c.inc
+++ b/target/riscv/insn_trans/trans_rvv.c.inc
@@ -3172,7 +3172,6 @@ static void load_element(TCGv_i64 dest, TCGv_ptr base,
          break;
      default:
          g_assert_not_reached();
-        break;
      }
  }

@@ -3257,7 +3256,6 @@ static void store_element(TCGv_i64 val, TCGv_ptr base,

          break;
      default:
          g_assert_not_reached();
-        break;
      }
  }

Reviewed-by: Richard Henderson <richard.hender...@linaro.org>

r~