Re: [PATCH 11/39] target/ppc: replace assert(0) with g_assert_not_reached()

[Pierrick Bouvier]

On 9/10/24 20:14, Richard Henderson wrote:

On 9/10/24 15:15, Pierrick Bouvier wrote:

Signed-off-by: Pierrick Bouvier <pierrick.bouv...@linaro.org>
---
   target/ppc/dfp_helper.c | 8 ++++----
   target/ppc/mmu_helper.c | 2 +-
   2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/target/ppc/dfp_helper.c b/target/ppc/dfp_helper.c
index 5967ea07a92..6ef31a480b7 100644
--- a/target/ppc/dfp_helper.c
+++ b/target/ppc/dfp_helper.c
@@ -249,7 +249,7 @@ static void dfp_set_FPRF_from_FRT_with_context(struct 
PPC_DFP *dfp,
           fprf = 0x05;
           break;
       default:
-        assert(0); /* should never get here */
+        g_assert_not_reached(); /* should never get here */
       }
       dfp->env->fpscr &= ~FP_FPRF;
       dfp->env->fpscr |= (fprf << FPSCR_FPRF);
@@ -1243,7 +1243,7 @@ void helper_##op(CPUPPCState *env, ppc_fprp_t *t, 
ppc_fprp_t *b) \
           } else if (decNumberIsQNaN(&dfp.b)) {                  \
               vt.VsrD(1) = -2;                                   \
           } else {                                               \
-            assert(0);                                         \
+            g_assert_not_reached();                                         \
           }                                                      \

Backslashes should ideally be kept aligned.

Reviewed-by: Richard Henderson <richard.hender...@linaro.org>


r~

I'll align those.
Thanks,
Pierrick