Looks good.

Looking at the patch again I'm wondering if using globals in qemu is still 
encouraged.
I know it's a common pattern today, but seeing efforts like the multiarch 
binary or Unicorn
I'm wondering if there is aspirations to do things more "cleanly", in general, 
for far out benefits?
I.e. memory_limit could be a machine property instead.

Yes, I'll rework that code to simply store it in the machine, moving that code out of cpu-sysemu.c int s390-virtio-ccw.c.

Same for patch #12, thanks!

--
Cheers,

David / dhildenb


Reply via email to