On Tue, Oct 01, 2024 at 07:46:09AM +0200, Markus Armbruster wrote: > Command query-migrationthreads went in without a QAPI ACK. Issues > review should have caught: > > * Flawed documentation. Fixed in commit e6c60bf02d1. > > * It should have been spelled query-migration-threads. Not worth fixing > now, I guess. > > * What are the use cases? The commit message doesn't tell! If it's > just for debugging, the command should be marked unstable.
It is hard to use too. Lets say a mgmt app wants to restrict migration threads to some certain pCPUs. It can't call query-migrationthreads beforehand as the threads don't exist until migration is started. If it calls after migration is started, then there's a window where threads are running on arbitrary pCPUs that QEMU has access to. There's no synchronization point where threads have been created & can be queried, but are not yet sending data (and thus burning CPU time) With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
