On Tue, 1 Oct 2024, Bernhard Beschow wrote:
Am 15. August 2024 19:01:47 UTC schrieb Bernhard Beschow <shen...@gmail.com>:
Am 16. Juli 2024 12:07:57 UTC schrieb BALATON Zoltan <bala...@eik.bme.hu>:
Add booke206_set_tlb() utility function and use it to replace very
similar create_initial_mapping functions in e500 machines.

Signed-off-by: BALATON Zoltan <bala...@eik.bme.hu>
---
[...]
-    mmubooke_create_initial_mapping(env);
+    /* create initial mapping */
+    booke206_set_tlb(tlb, 0, 0, map_size);

Both invocations of booke206_set_tlb() are followed by:

+#ifdef CONFIG_KVM
+    env->tlb_dirty = true;
+#endif

Doesn't it make sense to move these three lines into booke206_set_tlb()? The 
two copies you're resolving did so, too.

Ping

Did not forget but had no time to look at it yet. I'll come back to it when I'll have time.

Regards,
BALATON Zoltan


Best regards,
Bernhard

Reply via email to